feat: prepare circuit output for validation#6678
Merged
Conversation
Contributor
Changes to circuit sizes
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
Collaborator
|
just merged master as I noticed it had a fix for your CI failure :) |
Collaborator
Benchmark resultsMetrics with a significant change:
Detailed resultsAll benchmarks are run on txs on the This benchmark source data is available in JSON format on S3 here. Proof generationEach column represents the number of threads used in proof generation. | Metric | | L2 block published to L1Each column represents the number of txs on an L2 block published to L1.
L2 chain processingEach column represents the number of blocks on the L2 chain where each block has 16 txs.
Circuits statsStats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.
Stats on running time collected for app circuits
Tree insertion statsThe duration to insert a fixed batch of leaves into each tree type.
MiscellaneousTransaction sizes based on how many contract classes are registered in the tx.
Transaction size based on fee payment method | Metric | | |
…to lw/circuit_output_validation
LeilaWang
commented
May 28, 2024
| tx_request.tx_context, | ||
| ); | ||
|
|
||
| public_inputs.min_revertible_side_effect_counter = private_call_public_inputs.min_revertible_side_effect_counter; |
Contributor
Author
There was a problem hiding this comment.
Assigning the min counter in propagate_from_private_call instead, which is run by both init and inner.
LeilaWang
commented
May 28, 2024
| } | ||
|
|
||
| #[test] | ||
| fn propagate_max_block_number_request() { |
Contributor
Author
There was a problem hiding this comment.
Tests for propagating data are done in the tests for PrivateKernelCircuitPublicInputsComposer.
LeilaWang
commented
May 28, 2024
| assert( | ||
| note_logs[i].note_hash_counter | ||
| == self.public_inputs.end.new_note_hashes.get_unchecked(note_index).counter(), "Could not find note hash linked to note log." | ||
| assert(note_index < new_note_hashes.len(), "Could not find note hash linked to note log"); |
Contributor
Author
There was a problem hiding this comment.
Need to check against the number of non-empty items. Otherwise, we would be allowing a log to link to counter 0.
sirasistant
approved these changes
May 28, 2024
Contributor
sirasistant
left a comment
sirasistant
left a comment
There was a problem hiding this comment.
Looks great! And the reduction in constraints is enormous! Only some very small nits 🥳
| for i in 0..dest.len() { // Loop through dest instead of source because we also need to check that dest is appended with empty items. | ||
| should_check |= i == num_prepended_items; // Prepended items have been checked in validate_array_prepended() and can be skipped here. | ||
| if should_check { | ||
| is_non_empty_item &= i != items_propagated; |
Contributor
There was a problem hiding this comment.
We can probably extract this one out of the if should_check and maybe same some constraints 🤓
| for i in 0..dest.len() { | ||
| should_check |= i == num_prepended_items; | ||
| if should_check { | ||
| is_non_empty_item &= i != items_propagated; |
noir-projects/noir-protocol-circuits/crates/private-kernel-lib/src/private_kernel_init.nr
Outdated
Show resolved
Hide resolved
TomAFrench
added a commit
that referenced
this pull request
May 29, 2024
* master: feat: prepare circuit output for validation (#6678) chore: stop building/publishing `acvm_backend.wasm` (#6584) chore: add bench programs (#6566) chore: make public data update requests, note hashes, and unencrypted logs readonly in TS (#6658) git subrepo push --branch=master noir-projects/aztec-nr git_subrepo.sh: Fix parent in .gitrepo file. [skip ci] chore: replace relative paths to noir-protocol-circuits git subrepo push --branch=master barretenberg feat: update honk recursion constraint (#6545) feat: Add code-workspace and update build dirs (#6723) feat: Sync from noir (#6717) feat: folding acir programs (#6685) feat: sumcheck part of ECCVM recursive verifier instantiated as an UltraCircuit (#6413)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing private kernel init and inner to:
The checks are done in a new component:
private_kernel_circuit_output_validator.nr.